Fixed email address validation regex #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code is escaping a back slash instead of escaping the dot, but the expression fails subdomains check such as @gmail.com.edu so there is a community pattern is already a good fit and works flawlessly so far so it is added into the commit
|
Hey @HazemSayad thank you once again for helping the repository out, I just had one question, it doesn't seem to match uppercase emails now, was that the case even with the initial regex? |
|
hello @monizb
the expression should work on both uppercase and lowercase letters since i am ending the expression with the
You are most welcome, i find it a very helpful extension and i found an opportunity to help so here i am. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original latest code is escaping a back slash instead of escaping the dot, but the expression fails subdomains check such as
@gmail.com.eduso there is a community pattern that is already a good fit and works flawlessly so far so it is added into the commitPlease check if the PR fulfills these requirements:
What is the current behavior?
fixes #21
Also fixes email validation regex snippet where there was a typo maybe and instead of escaping the dot
.the character being escaped was a backslash\.What is the new behavior?
Matches emails correctly and works with subdomains as well such as
@gmail.com.eduOther information?
This is a significant change and improves on the email validation regex snippet
Tested manually on https://regexr.com/
Credits to the expression goes to: https://regexr.com/2rhq7